Repository navigation
Word the tail-part comma report without naming a field (#629) - #630
Merged
Merged
Conversation
Segment's comma-structure report on a part past the second comma said the part was "consumed as suffix best-effort". Since #603 a title word there reads as a title, so `John Smith, Jr., Dr. Bart` was told 'Dr.' was a suffix (this cycle, never shipped). #626's field_tail names only the first referent's field, and one part's words land in two, so PendingAmbiguity gains fields_tail: assemble names every field the referents hold, by role name in canonical order ("consumed as title and suffix best-effort"). A part landing wholly in suffix keeps the wording every release gave it. The field sweep reads the phrase and checks it for equality; its control is 6 failures on master, and the recorded claim count moves from 1155 to 1180. Measured against master over the corpora, the case table and a 97,650-text tail grid under three orders: only the detail of comma-structure reports on a part holding a title moves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #630 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 46 46
Lines 4486 4486
=======================================
Hits 4442 4442
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Replaces 0d5fea4's mechanism with the simpler fix the issue offered: the comma-structure report on a part past the second comma now says "beyond the recognized comma structures; read best-effort" and names no field, since the part's words can land in two and the fields say where each went. The input is malformed, so the report is not worth machinery. Reverts PendingAmbiguity.fields_tail, assemble's branch for it, the field guard's equality check and the A1 clause. Review of 0d5fea4 found that branch withdrew the report from a name emptied of content (", , -"), against rules.md#A2; with nothing worded at assemble that case keeps its report as on master. Measured against master over the corpora, the case table and the tail grid under three orders: only the detail of comma-structure reports moves, and no report appears or goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derek73
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Segment's
comma-structurereport on a part past the second comma said the part was "consumed as suffix best-effort". That was true through 2.3.0, when the whole part read as suffix. Since #603 (rules.md#C2), a title word there reads as a title, so the report named a field the word isn't in. That happened this cycle and never shipped.The report now names no field:
John Smith, Jr., Dr. BartJohn Smith, Jr., BartIt says what is certain, that the part is beyond the recognized comma structures, and the fields say where each word went. The input is malformed, so the fix is one string, not machinery. Report kinds are unchanged; only the detail text moves.
History
The first commit (0d5fea4) named every field the part's words land in ("consumed as title and suffix best-effort"), worded at assemble from the final roles. Review found that it withdrew the report from a name emptied of content (
", , -"), against rules.md#A2, and it needed a second tail onPendingAmbiguity, an assemble branch and an equality check in the field guard. The second commit (14c750d) reverts all of that for the neutral wording. decisions.md#A1's entry records the declined design and why.Measured (decisions.md#A1, 2026-10-10)
Against master bc24386, comparing every report's kind, detail and referents plus the seven fields:
comma-structurereports (90 in the named texts, 247,353 in the grid). No report appears or goes;", , -"keeps its report as on master.Tests
test_segment.py: the report's verbatim detail onJohn Smith, Jr., Dr. Bart.test_a_report_names_the_field_its_word_lands_in) is unchanged: the new wording names no field, so there is nothing for it to check.Docs
Open: #629line.Smith, Jr., Dr. Bartreports its last part as "consumed as suffix" when 'Dr.' is read as a title #629 notes now say the report names no field.John Smith, PhD Jonesreads familyJohn Smith#603 bullet shows the new wording throughparse(...), and closesSmith, Jr., Dr. Bartreports its last part as "consumed as suffix" when 'Dr.' is read as a title #629.Closes #629
🤖 Generated with Claude Code